Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More verbose error in service backend #1490

Merged
merged 14 commits into from
Nov 27, 2019
Merged

More verbose error in service backend #1490

merged 14 commits into from
Nov 27, 2019

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Nov 7, 2019 •
edited by NicolasMahe
Loading

Closes #1471

@krhubert krhubert added the enhancement New feature or request label Nov 7, 2019
@krhubert krhubert added this to the next milestone Nov 7, 2019
@krhubert krhubert self-assigned this Nov 7, 2019
NicolasMahe
NicolasMahe reviewed Nov 11, 2019
View reviewed changes
sdk/service/backend.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe reviewed Nov 11, 2019
View reviewed changes
cosmos/errors.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe reviewed Nov 11, 2019
View reviewed changes
cosmos/errors.go Outdated Show resolved Hide resolved
@krhubert
Copy link
Contributor Author

The point here is to set up the codespaces and codes - what we want to use.

@krhubert krhubert mentioned this pull request Nov 13, 2019
Closed
@NicolasMahe NicolasMahe changed the title More verbose error in servcie backend More verbose error in service backend Nov 14, 2019
@NicolasMahe
Copy link
Member

NicolasMahe commented Nov 19, 2019 •
edited
Loading

@krhubert could you finish this PR by applying what we said:

After meeting with @krhubert, we decided to implement one new CodespaceType mesg that will contains error related to the project added value (running services, executions, processes) and not to error related to the blockchain (those one should use the sdk codespace defined by cosmos.

We will also implement new CodeType for any error that is not already defined by cosmos.

@krhubert
More verbose error in backends
ad411f5 
- craete cosmos codespace for mesg
- create newMesgError functions
@krhubert krhubert marked this pull request as ready for review November 19, 2019 19:45
NicolasMahe
NicolasMahe requested changes Nov 20, 2019
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments and fix lint ;)
I also push a new commit that add the error wrapper to 2 error in cosmos.NewQuerierHandler func.

cosmos/errors.go Outdated Show resolved Hide resolved
cosmos/errors.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe reviewed Nov 21, 2019
View reviewed changes
cosmos/errors.go Outdated Show resolved Hide resolved
@NicolasMahe
Copy link
Member

An idea: could we both implement cosmos and grpc error at the same times?
it will be really great for the client to be able to receive directly the cosmos error and be able to extract the error code ;)

NicolasMahe
NicolasMahe reviewed Nov 22, 2019
View reviewed changes
server/grpc/server.go Outdated Show resolved Hide resolved
@NicolasMahe NicolasMahe modified the milestones: v0.17.0, next Nov 25, 2019
NicolasMahe
NicolasMahe requested changes Nov 27, 2019
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the grpc interceptor and create a new PR just containing it.

NicolasMahe
NicolasMahe approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the last modif and merge

@krhubert krhubert merged commit e06baf9 into dev Nov 27, 2019
@krhubert krhubert deleted the feature/cosmo-error branch November 27, 2019 12:51
@NicolasMahe NicolasMahe added the release:change Pull requests that change something existant label Dec 13, 2019
@NicolasMahe NicolasMahe mentioned this pull request Dec 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees

@krhubert krhubert

Labels
enhancement New feature or request release:change Pull requests that change something existant
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.

Use cosmos errors for the backend
2 participants
@krhubert @NicolasMahe